Welcome to reborn wo/man! Always nice to see someone jump in again!
Don't forget about the physical/special split. Up until gen3 all fire, water, grass, electric, dark, psychic, dragon and ice were special(uses sp.atk vs sp.def) with the rest being physical(uses atk vs def). This was changed in gen 4 so now attacks are physical or special depending on flavor text
For eg: fire/ice/thunder punch are physical(ur atk vs opp def) while mudbomb/shadowball/flashcannon are special. Check bulbapedia for more info.