[Noted] Shell Bell fixed.. Maybe..

[Yash 4]

So i think i managed fixing the shell bell error.. Cuz i got it to heal around 12-16 HP attacking level 44 pokemon..

Amethyst if you can just check and confirm..

I made a change to the PokeBattle_Battler script.

Line 2274 was changed to

hpgain=user.pbRecoverHP([(damage/8).floor].min,true)

from

hpgain=user.pbRecoverHP([(damage/8).floor,1].min,true)

Full code without the changed line..

# Shell Bell

if isConst?(user.item,PBItems,:SHELLBELL) && damage>0 && user.hp>0

hpgain=user.pbRecoverHP([(damage/8).floor,1].min,true)

if hpgain>0

@battle.pbDisplay(_INTL("{1}'s Shell Bell restored its HP a little!",user.pbThis))

end

end

i'm guessing the 1 after " (damage/8).floor " part was restricting it.. so i removed the comma and 1.. and i guess its fine now..

i'm not sure about the amount of HP gained..

EDIT: i tested it out and it was the 1.. i made it 4 and gained 4 hp.. so i guess its fixed..

EDIT 2: the same also should be done on line 2407

[Arkhi 199]

Is Damage defined by how much total damage you deal, after factoring in the foe's defenses? Or the value of HP you deal?
I ask because raw damage can reach the thousands, but HP goes no higher than 714, Blissey's max.

[Yash 4]

Damage is calculated based on the hp lowered.. Atleast it functions like that.. The rhyhorn i was battling at level 44 with a moderate iv for hp has total hp close to 130-140.. So when i OHKO'd it, 16 hp was restored for my poke..

Will edit the post in sometime and add the full script so you can confirm..

[Arkhi 199]

I don't know RGSS, so I can't confirm if it works. Just asking for the record. It's never a bad thing to have too much info on the matter.

[Jericho 114]

I THINK someone beat you to it.

http://www.pokemonreborn.com/forum/index.php?showtopic=8671entry154994

[Yash 4]

hmm.. let me try his way and check...

EDIT: I think it works.. so now we have two ways to fix it..

[DJ Mewdeon ft Dan Punk 43]

hmm.. let me try his way and check...

EDIT: I think it works.. so now we have two ways to fix it..

Sorry mate, the other fix is correct and already implemented. I appreciate your effort in attempting it nonetheless.

[Amethyst 2469]

Three, actually. Someone else pm'd me a different fix as well. Incidentally, all of them have been different.

Basically Shell Bell will be fixed for 13, if not extremely fixed, whatever that means.