= vs == typo

[Aeodyn 18]

PokeBattle_Move:2089

Before:

if (id == PBMoves::PETALBLIZZARD || id == PBMoves::PETALDANCE || id == PBMoves::FLEURCANNON) && $fecounter = 2

After:

if (id == PBMoves::PETALBLIZZARD || id == PBMoves::PETALDANCE || id == PBMoves::FLEURCANNON) && $fecounter == 2

I noticed it with mkxp-z's console=true build option.

[andracass 1148]

i think we've caught that one already

but i'd also like to offer this

def isConst?(val,mod,constant)
  begin
    return (val==mod.const_get(constant.to_sym))
  rescue
    print("broken constant #{constant}")
    return false
  end
end

the current isconst? function doubles up the amount of work needed to check if a constant exists and then doesn't tell you that a constant is mistyped

i don't want to force extra work on you, but if you're already paying attention to the console this may make broken constants easier to find.

[Aeodyn 18]

Oh wow, I see what you mean. Cool.

Just seen "AIRBALLON" and "ABOMBASNOW" so far.